Bullish exchange integration #25884
Draft
Bullish exchange integration #25884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosmiei
reviewed
Jun 11, 2025
carlosmiei
reviewed
Jun 11, 2025
carlosmiei
reviewed
Jun 11, 2025
carlosmiei
reviewed
Jun 11, 2025
carlosmiei
reviewed
Jun 11, 2025
| }, market); | ||
| } | ||
|
|
||
| async safeDeterministicCall (method: string, symbol: Str = undefined, since: Int = undefined, limit: Int = undefined, timeframe: Str = undefined, params = {}) { |
There was a problem hiding this comment.
hum why we need this method here?
There was a problem hiding this comment.
If we provide until in params the exchange will return the latest limit entries. In this case all calls of the method by fetchPaginatedCallDeterministic will return the same entries. Thus we have to delete until from params before calling the method.
carlosmiei
reviewed
Jun 11, 2025
carlosmiei
reviewed
Jun 11, 2025
carlosmiei
reviewed
Jun 11, 2025
carlosmiei
reviewed
Jun 11, 2025
carlosmiei
reviewed
Jun 11, 2025
carlosmiei
reviewed
Jun 11, 2025
|
@AresArtemius I think we're missing the |
carlosmiei
reviewed
Jun 11, 2025
carlosmiei
reviewed
Jun 11, 2025
carlosmiei
reviewed
Jun 11, 2025
| this.orderbooks[symbol] = this.orderBook (); | ||
| } | ||
| const orderbook = this.orderbooks[symbol]; | ||
| const bids = this.separateBidsOrAsks (this.safeList (data, 'bids', [])); |
There was a problem hiding this comment.
you sure we need this method? why?
There was a problem hiding this comment.
Both price and amount are in the same array without any key to distinguish.
Even indexes (including 0) are prices, odd indexes are amounts. I don't know how to handle it in a different way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.