8000 feat(hyperliquid) - fetchCurrencies precision by ttodua · Pull Request #24449 · ccxt/ccxt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(hyperliquid) - fetchCurrencies precision #24449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

feat(hyperliquid) - fetchCurrencies precision #24449

wants to merge 17 commits into from

Conversation

ttodua
Copy link
Member
@ttodua ttodua commented Dec 4, 2024 •
edited
Loading

@carlosmiei
Copy link
Collaborator

@ttodua can you update the static currencies?

@ttodua
Copy link
Member Author
ttodua commented Dec 4, 2024 •
edited
Loading

Sure, i'll update things, just wanted to get some feedback on this precision (whether there is something more behind it that I am aware of)

@ttodua ttodua marked this pull request as draft May 26, 2025 17:01
@ttodua
Copy link
Member Author
ttodua commented Jun 24, 2025 •
edited
Loading

@gaardiolor I haven't seen you ever touched this part. wdyt, any objections here?

@ttodua ttodua marked this pull request as ready for review June 24, 2025 13:57
ttodua
ttodua commented Jun 24, 2025
View reviewed changes
ts/src/test/static/response/hyperliquid.json
@@ -3,55 +3,6 @@
"skipKeys": [],
"options": {},
"methods": {
"fetchCurrencies": [
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

multi-endpoints can't be tested

@gaardiolor
Copy link
Contributor

Hi @ttodua ,

I think I never tested fetch_currencies. From first glance it seems that freqtrade is not using it.

Now that I'm looking at it, I'm not sure what the objective is? (The ccxt manual also doesn't really mention much about fetch_currencies)

According to https://discord.com/channels/1029781241702129716/1087879542049357935/1319402137129586688 , weidecimals is the smallest unit of the asset. But, of the token, on the blockchain. According to this post it's not relevant for trading, for trading szDecimals should be used: "Trading is based on szDecimals which is the smallest tradable unit"

According to https://hyperliquid.gitbook.io/hyperliquid-docs/hyperliquid-improvement-proposals-hips/hip-1-native-token-standard , it's also for the token itself, not for trading.

This post also mentions it in the context of launching a new token: https://discord.com/channels/1029781241702129716/1029781241702129719/1375535827290951962

So I'm not sure weidecimals is relevant for ccxt?

@ttodua
Copy link
Member Author
ttodua commented Jun 25, 2025

Hi @ttodua ,

I think I never tested fetch_currencies. From first glance it seems that freqtrade is not using it.

Thanks for reply. the added field here (precision) in fetchCurrencies is used when withdrawing the token from exchange. anyway, as you didn't have any strong use of fetchCurrencies and don't have any objections, I'll pass this for final review.

@ttodua
Copy link
Member Author
ttodua commented Jun 25, 2025

@carlosmiei I think this is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kroitor kroitor Awaiting requested review from kroitor kroitor is a code owner

@frosty00 frosty00 Awaiting requested review from frosty00 frosty00 is a code owner

@carlosmiei carlosmiei Awaiting requested review from carlosmiei carlosmiei is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@carlosmiei carlosmiei

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ttodua @carlosmiei @gaardiolor
0