8000 NDAX, fetch_order_book returns only asks and empty bids · Issue #9019 · ccxt/ccxt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

NDAX, fetch_order_book returns only asks and empty bids #9019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rallis opened this issue Apr 18, 2021 · 2 comments
Closed

NDAX, fetch_order_book returns only asks and empty bids #9019

rallis opened this issue Apr 18, 2021 · 2 comments
Assignees
@kroitor
Labels
bug

Comments

@rallis
Copy link
Contributor
rallis commented Apr 18, 2021 •
edited
Loading
  • OS: MacOS 10.14
  • Programming Language version: Python
  • CCXT version: latest master (3863b5e)
For Exchange  NDAX,  fetch_order_book returns only asks and empty bids.  
The call to the exchange is correct, response is fine, the bug is while parsing the response.
Type conversion string VS int of levelSide variable is causing it.

https://github.com/ccxt/ccxt/blob/master/python/ccxt/ndax.py#L388-L389
and
https://github.com/ccxt/ccxt/blob/master/python/ccxt/ndax.py#L421

int(levelSide) OR
levelSide == '0'
fixes it.

I can submit a PR for python but not sure if the PR needs to fix it in all three languages.
@rallis
Copy link
Contributor Author
rallis commented Apr 18, 2021

Submitted this PR for fixing it
#9020

@kroitor kroitor self-assigned this Apr 19, 2021
@kroitor
Copy link
Member
kroitor commented Apr 19, 2021

@rallis thank you!

@kroitor kroitor added the bug label Apr 19, 2021
kroitor added a commit that referenced this issue Apr 19, 2021
@kroitor
Merge pull request #9020 from rallis/master
f69ac7d 
Fix empty bids list in python for NDAX exchange #9019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kroitor kroitor

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kroitor @rallis
0