8000 loadMarkets incorrectly shows limits for Poloniex · Issue #4800 · ccxt/ccxt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

loadMarkets incorrectly shows limits for Poloniex #4800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
burzakovskiy opened this issue Mar 7, 2019 · 1 comment
Closed

loadMarkets incorrectly shows limits for Poloniex #4800

burzakovskiy opened this issue Mar 7, 2019 · 1 comment
Assignees
@kroitor
Labels
duplicate question

Comments

@burzakovskiy
Copy link
  • OS: Ubuntu
  • Programming Language version: Node.js 11.10.0
  • CCXT version: 1.18.347
  • Exchange: Poloniex
  • Method: loadMarkets

After upgrade from 1.18.304 to 1.18.347 loadMarkets started to show limits incorrectly for Poloniex


const exchange = new ccxt['poloniex']()

exchange.loadMarkets().then(()=>{
	console.log(exchange.markets['BTC/USDT'].limits)
})

1.18.347 Output

{ amount: { min: 0.000001, max: 1000000000 },
  price: { min: 1e-8, max: 1000000000 },
  cost: { min: 0, max: 1000000000 } }

1.18.304 Output

{ limits:
   { amount: { min: 0.000001, max: undefined },
     price: { min: 1e-8, max: undefined },
     cost: { min: 1, max: undefined } }

As you see old version shows correct costs while newer shows 0
@kroitor kroitor self-assigned this Mar 7, 2019
@kroitor
Copy link
Member
kroitor commented Mar 7, 2019 •
edited
Loading

Please, follow here: #4777. Those cost minimums were deduced from precision in previous versions which was semantically incorrect, that post explains why the actual min cost is unknown and unspecified by Poloniex. I suggest to move this discussion to that PR if you don't mind. Thx!

@kroitor kroitor closed this as completed Mar 7, 2019
kroitor added a commit that referenced this issue Mar 8, 2019
@kroitor
poloniex min cost fix #4777 fix #4800
5e545a 5060 6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kroitor kroitor

Labels
duplicate question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kroitor @burzakovskiy
0