8000 Name normalization MGO / EMGO / MGO (ETH) / MGO (WAVE) · Issue #1487 · ccxt/ccxt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Name normalization MGO / EMGO / MGO (ETH) / MGO (WAVE) #1487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pmizel opened this issue Jan 25, 2018 · 7 comments
Closed

Name normalization MGO / EMGO / MGO (ETH) / MGO (WAVE) #1487

pmizel opened this issue Jan 25, 2018 · 7 comments
Assignees
@kroitor

Comments

@pmizel
Copy link
Contributor
pmizel commented Jan 25, 2018

there is an issue with name convention for Mobile Go,

liqui use MGO and is MGO on Etherium
tidex use MGO and is MGO on Waves
tidex use EMGO and is MGO on Etherium

do we need some name normalization?
@kroitor kroitor self-assigned this Jan 25, 2018
@kroitor
Copy link
Member
kroitor commented Jan 25, 2018 •
edited
Loading

Yes, we do. Check this out: https://github.com/ccxt/ccxt/blob/master/js/liqui.js#L102
Also: #1330 (comment)

One of them should be MGO, and the other one should be renamed. I guess, MGO on ETH has greater market cap.

@kroitor
Copy link
Member
kroitor commented Jan 25, 2018

What would you propose? Rename MGO → WMGO and EMGO → MGO on tidex?

@pmizel
Copy link
Contributor Author
pmizel commented Jan 25, 2018

i know MGO is short and nice but not specific, meybe is better to use EMGO and WMGO for unique identity
but i'm not shure.

HitBTC use EMGO as name too.

@kroitor
Copy link
Member
kroitor commented Jan 25, 2018 •
edited
Loading

We tend to use coinmarketcap symbols... And CMC uses MGO. 75% exchanges will list the eth-variant under MGO, others will use a unique name.

Here it is:


node examples/js/search-all-exchanges.js MGO

...

--------------------------------------------------------------- (test @ search-all-exchanges.js:90)

Currencies: (test @ search-all-exchanges.js:92)

id    code  exchange       name               active  status  fee  type    payin  payout  transfer
--------------------------------------------------------------------------------------------------
MGO   MGO   allcoin                                                                               
MGO   MGO   coinmarketcap  MobileGo           true    ok                                          
MGO   MGO   cryptopia      MobileGo           true    ok      4                                   
MGO   MGO   gatecoin                                                                              
EMGO  EMGO  hitbtc                                                                                
WMGO  WMGO  hitbtc                                                                                
EMGO  EMGO  hitbtc2        MobileGo           true    ok           crypto  true   true    true    
WMGO  WMGO  hitbtc2        MobileGo on WAVES  false   ok           crypto  false  false   true    
MGO   MGO   liqui                                                                                 
EMGO  EMGO  tidex                                                                                 
MGO   MGO   tidex                                                                                 
MGO   MGO   yobit                                                                                  (test @ search-all-exchanges.js:104)

@kroitor
Copy link
Member
kroitor commented Jan 25, 2018 •
edited
Loading

Notice that WMGO is switched off with HitBTC (at least, now), btw.

@pmizel
Copy link
Contributor Author
pmizel commented Jan 25, 2018

I agree. lets do it ;-)

how can i help?

@kroitor
Copy link
Member
kroitor commented Jan 25, 2018 •
edited
Loading

how can i help?

From above it follows that we need to edit two exchanges:

  1. HitBTC
  2. Tidex

For HitBTC we just need to add overrides here:

For Tidex we need to copy the base method from Liqui and then add overrides to it:

If you are going to give it a try, please do one exchange at a time. Thx!

kroitor added a commit that referenced this issue Jan 25, 2018
@kroitor
hitbtc v1, v2 EMGO → MGO, #1487
d6fec78
kroitor added a commit that referenced this issue Jan 25, 2018
@kroitor
tidex MGO → WMGO, EMGO → MGO, #1487
7c4df3d
@kroitor kroitor closed this as completed Jan 25, 2018
@kroitor kroitor mentioned this issue Feb 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kroitor kroitor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kroitor @pmizel
0