Use image files from dials-data image_examples, not from dials_regression
#801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ould be got around by copying image reading code from iotbx into get_raw_data, ensuring the file is only opened by the compressoin-aware Format class open_file method.
This ends up testing far fewer images than before, because detectorbase cannot be instantiated on compressed images, where they are opened without dxtbx's transparent compressed file opening system. But we do not generally use detectorbase anyway.
…ages.py::test_format_class_API_assumptions
adequately tested now anyway by the compressed images on dials-data
|
Agreement to merge from DIALS-core |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves many more dxtbx tests to use
dials-data, though not yet all. There are some changes to what gets tested, in particular, compressed files do not get adetectorbaseset up, as this involves file reads in iotbx, outside of dxtbx's transparent compressed file reading functionality.On the other hand, a
get_raw_datamethod was added toFormatRAXISand derivatives, so that these images could be read when compressed. That allowedtest_imageset.py::test_formatto run without error on those images.Clean up a few other areas, like deleting
test_datablock.py, which contained no tests.