Refactor panel positions of FormatISISSXD #762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in panel positions depending on the date of data collection.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #762 +/- ##
=======================================
Coverage 41.59% 41.60%
=======================================
Files 189 189
Lines 17074 17103 +29
Branches 3276 3281 +5
=======================================
+ Hits 7102 7115 +13
- Misses 9318 9330 +12
- Partials 654 658 +4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors panel positions of
FormatISISSXDto account for differences depending on the date of data collection. Panel positions have been modified several times over the instrument's lifetime and this is now accommodated for by checking the start date of the experiment when loading the detector.