8000 Stop attempting "legacy editable" installs by dwpaley · Pull Request #1070 · cctbx/cctbx_project · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Stop attempting "legacy editable" installs #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 2, 2025
Merged

Stop attempting "legacy editable" installs #1070

merged 3 commits into from
May 2, 2025

Conversation

dwpaley
Copy link
Contributor
@dwpaley dwpaley commented May 1, 2025

Legacy-editable mode was removed in pypa/setuptools#4953, this env
variable no longer does anything. We accommodate the new behavior in
cctbx/dxtbx#807 and dials/dials#2906.

dwpaley added 3 commits April 30, 2025 18:10
@dwpaley
let bootstrap install dxtbx and dials again
b0c1a2c
@dwpaley
Stop attempting "legacy editable" installs
11d1179 
Legacy-editable mode was removed in pypa/setuptools#4953, this env
variable no longer does anything. We accommodate the new behavior in
cctbx/dxtbx#807 and dials/dials#2906.
@dwpaley
Stop "Stop attempting "legacy editable" installs"
003560a 
This reverts commit 11d1179.
@dwpaley
Copy link
Contributor Author
dwpaley commented May 1, 2025 •
edited
Loading

We can't get rid of legacy editable mode because some builders are pinned to previous versions of dials and dxtbx. Those old versions still expect (in libtbx_refresh.py) to have been installed in legacy editable mode, therefore they add e.g. modules/dials/src to the pythonpath instead of build/dials/lib/python3.x/site-packages. For those builders (at least cctbx and phenix) we will just have to keep setuptools <79 as long as the dials and dxtbx versions remain pinned. For this PR I'll just remove Aaron's workaround in the tests, and scrap the other part for the foreseeable.

@bkpoon
Copy link
Member
bkpoon commented May 1, 2025

We can bump up those versions to 3.22. That's the version that we're shipping with Phenix right now since it's the last version to support Python 3.9. The pinned versions in bootstrap.py are because those builders only need things to compile.

@dwpaley dwpaley merged commit 5757432 into master May 2, 2025
101 checks passed
@dwpaley dwpaley deleted the xfel_revert_workaround branch May 2, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dwpaley @bkpoon
0