Increased maximum number of runs to 8192 #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
althea-hansel
approved these changes
Aug 21, 2023
|
E50s for cuda version with 100 runs look good, approving. |
diogomart
approved these changes
Nov 16, 2023
|
@diogomart Thank you very much! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increases the maximum number of runs from 1000 to 8192. Besides simply changing the MAX_NUM_OF_RUNS define, in order for Cuda not to waste GPU memory it now, like OpenCL, allocates memory based on the actual settings of the number of runs and the population size instead of their max values.
This requires a little bit of additional testing on the Cuda side.