Switch from pipenv to uv and add pre-commit with ruff formatting #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeancochrane
commented
Apr 10, 2025
wrridgeway
approved these changes
Apr 10, 2025
| - name: Setup Python | ||
| uses: actions/setup-python@v4 | ||
| - name: Install uv | ||
| uses: astral-sh/setup-uv@v3 |
There was a problem hiding this comment.
Any reason not to use v4 or v5? Purely just curiosity.
There was a problem hiding this comment.
Good catch! I didn't realize there'd been so many new releases recently. I double-checked the changelog and all looks good, so I updated to v5 in 088630f and confirmed it executes correctly in this workflow run.
* Clean up and improve deduplication * Remove unnecessary log line from permit_cleaning.py * Remove note about code not yet being used in production
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes two small changes to the codebase to bring it in line with our emerging Python standard:
It also cleans up the code and improves deduplication per #19.
See this workflow run for evidence that dependencies install successfully and the script doesn't throw any import errors when installing using uv.