8000 see #2605, #2061, #1735, probably others by GorillaSapiens · Pull Request #2747 · cc65/cc65 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

see #2605, #2061, #1735, probably others #2747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GorillaSapiens
Copy link
Contributor

i obviously don't have all these systems to test with.
let the argument commence...

@mrdudz
Copy link
Contributor
mrdudz commented Jun 26, 2025

this makes sense... would be nice if it:

  • prints DESTDIR (if not windows detected)
  • prints a warning if DESTDIR is empty (before setting the default, only if not windows)
  • prints a warning if "unknown" was detected (just that might result in some bsd or amiga guy to wake up...)

@GorillaSapiens
Copy link
Contributor Author
GorillaSapiens commented Jun 27, 2025
  • prints a warning if "unknown" was detected (just that might result in some bsd or amiga guy to wake up...)

if it's not windows, "/usr/local" should be fine. we could add AIX, Solaris, etc... but there's really no point in testing for a thing if it doesn't change what we do.

i suspect your hypothetical "amiga guy" will already know to be on the lookout for things to change. without an amiga to test on, and with no subject matter experts on the team, i would just not bother, and wait for someone who cares and knows what they are doing tell us what they need changed.

@mrdudz
Copy link
Contributor
mrdudz commented Jun 27, 2025

i suspect your hypothetical "amiga guy" will already know to be on the lookout for things to change. without an amiga to test on, and with no subject matter experts on the team, i would just not bother, and wait for someone who cares and knows what they are doing tell us what they need changed.

There is @polluks ... and i have an amige right here as well :)

In any case i am a friend of not doing things blindly - a warning in that case is totally justified

(also this is another thing that assumes we are compiling on the host... oh well)

@GorillaSapiens
Copy link
Contributor Author

i suspect your hypothetical "amiga guy" will already know to be on the lookout for things to change. without an amiga to test on, and with no subject matter experts on the team, i would just not bother, and wait for someone who cares and knows what they are doing tell us what they need changed.

There is @polluks ... and i have an amige right here as well :)

In any case i am a friend of not doing things blindly - a warning in that case is totally justified

(also this is another thing that assumes we are compiling on the host... oh well)

if i'm wrong and we DO have amiga experts here, we should add the test and they should just tell me what to use for a default DESTDIR

@mrdudz
Copy link
Contributor
mrdudz commented Jun 27, 2025

if i'm wrong and we DO have amiga experts here, we should add the test and they should just tell me what to use for a default DESTDIR

The problem starts with "compiling on the host". Your test would just give "linux" or "windows"

Anyway, useless discussion. That warning just should be there

@GorillaSapiens
Copy link
Contributor Author

The problem starts with "compiling on the host". Your test would just give "linux" or "windows"

sounds like you want a "canadian cross" compiler, which is a whole different set of issues. i would even argue that this is better handled outside the scope of this project entirely.

Anyway, useless discussion. That warning just should be there

NOT "useless". if we have amiga experts here who can tell us what a good default DESTDIR is for that platform, let's hear it !!!
i would MUCH rather "get it right" than "issue a lame warning that we probably got it wrong".
even if the right answer is "leave DESTDIR blank for Amiga", we CAN do that, it's not a problem.
i just need to know, i am not an Amiga expert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0