Fix -s vs QUIET in the makefiles #2746
Conversation
…UIET to submakefile(s)
…ctory depending on QUIET
|
but ofcourse windows blew up. gna |
|
Does this suppress all the useless clutter output to the screen when doing "make -s test"? |
thats the point :) |
|
so libsrc and src left... those will be most interesting :) |
…ake -s before might start doing it now :)
|
Should be all now... look at the log of the runner, this is with QUIET=1, -s will remove a few more things. The output of the windows runner gives an idea of how it looks with just "make" now, because somehow things dont work with it (feel free to chime in and fix) |
|
PS: for those that are wondering WTH happened - try Also: my argument against making it "very silent" by default, and then use V=1 to re-enable the output - and instead make it "verbose" by default and disable output on -s is:
Shoot (please propose a different scheme of how it should work - in the entire tree - if you dont agree with the OP. I am totally willing to change it to something different) |
nah not really :) just "make" gives you... all and everything |
|
I'm not 100% sure why I'm asked to review. So just a general remark: At the time I maintained this project, I considered it very relevant that it can be built on Windows. That had - as far as I remember - two reasons:
As a result I imagine getting rid of everything targeting cmd.exe as build environment is a totally viable option. |
Mostly because you wrote a lot of the Makefiles - and this PR changes the behaviour radically for at least libsrc and src (before it was non chatty by default, now you need to use -s) (i'd like to keep cmd.exe support around for a while. if only for @acqn - should he ever come back :)) |
|
Yes, I wrote those Makefiles - and I know that in several aspects you have a different perspective than I have (or rather had back then). Please go ahead and change them in any way you see fit. I'm a pure user of them - on WSL2 by now. As long as they still produce their files (be it with more or less screen output) I'm perfectly fine. Yes, @acqn is the contributor I had in mind above. |
Ah well :) right - merging. We can still change it to something else should that be desired |
Inspired by #2119
The idea is that:
makegives mostly "clean", but "all" output. in particular no stdout or stderr messages are suppressed, unless they are absolutely uselessmake QUIET=1gives a much less verbose output, it will suppress most output by the various tools, BUT when a tool errors out unexpectedly (!) and/or a test failed, then the output should be dumped to the console (*). Usually one status message per test is printed, to give some indicator of progress. This is the mode the CI/GHA usesmake -sis really the "no messages unless errors" mode, it inherits "QUIET=1", and supresses some more messages. Usually one status message per test is printed, to give some indicator of progress. And of course on errors all related info should still be dumped to console.(*) If some people could break random tests locally and see if that works as intended, that would be nice
PS: some of this may not work as advertised with cmd.exe - i have no idea. i tried to make the changes in a way that it would at least not break
done so far are "test" and "targettest" directories (most of "test" already worked that way), will check the rest as well and try to unify the behaviour a bit