Apple2: Fix permanently disabled IRQ #2745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libsrc/apple2/crt0.s
Outdated
| bne basic | ||
|
|
||
| ; We are running ProDOS, disable the IRQ/RST vector patching | ||
| sty patch_vectors |
There was a problem hiding this comment.
This is certainly "cool" as the $4C is already loaded but after all ONCE is declared as R/O: https://github.com/cc65/cc65/blob/master/cfg/apple2.cfg#L31
There was a problem hiding this comment.
Ha damn, I noticed done was patched and thought it was ok there :)
Do you have other ideas? using pla/and instead of plp was my first but it's hard to understand what it does at first sight, I find?
There was a problem hiding this comment.
done is deliberately placed in .data.
There was a problem hiding this comment.
I did forget to double-check that 😁
There was a problem hiding this comment.
Maybe a compromise between coolness and readibility?
lda $BF00
sec
sbc #$4C
pha
bne ...
[...]
pla
beq ...
There was a problem hiding this comment.
That's good, yes! Updated.
Regression introduced in 990d65e: Pushing status, initializing IRQ handler (which enables IRQ) then pulling status re-disables IRQ.
1b60014 to
3ec6fda
Compare
|
Thanks 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression introduced in 990d65e:
Pushing status, initializing IRQ handler (which enables IRQ) then pulling status re-disables IRQ.