-
Notifications
You must be signed in to change notification settings - Fork 458
m740 Support #2707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
m740 Support #2707
Conversation
So, it passes the regression test (that i added/updated too). One odd thing is that "inc a" and "dec a" are right now swapped (in both the assembler and the disassembler) - ie the documentation (that pdf) has them the other way around than currently implemented. This seems to follow the general logic of 6502 clones - however, we need to confirm whether this is really correct for the m740. @roberto314 do you remember anything about that? |
works too, and gives an identical file... now about the inc a/dec a.... |
So, for me this is mostly fine... let the dogs out, please comment - perhaps something can be done more elegant, please tell :) |
I am a bit surprised that I was asked to review -- my expertise is the simulator part of the codebase, and I know very little if anything about the other tools. Please proceed without my input :) |
removed some more unrelated stuff from the patch. Already spotted a few more little things - more for tomorrow :) |
@kugelfuhr perhaps you can skik over it as well? :) (Why cant i add you as reviewer? bleh) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't found much to complain about, but I have no knowledge of this cpu, so this was to be expected.
so there is the test. it got a bit out of hand :) A few more quirks show up, but they should be fixed in another PR (and the test updated) |
…ics ans ca65 uses seems like a good idea :)
ok thats it for me, will merge soon if noone steps in :) |
not sure which PDF you're referring to. i found this, if it is helpful: |
< 9E88 p dir="auto">not sure which PDF you're referring to. i found this, if it is helpful: https://bitsavers.org/components/mitsubishi/melps/1989_Series_740_Software_Users_Manual.pdf Thats the one, indeed. (@roberto314 linked to it in #986 ) It seems weird the INC A/DEC A doesn't follow the usual pattern. @roberto314 did you find any other software we could disassemble? |
Sorry, no luck. The code from the programmable logic unit is inside the
m50747, not in a ROM.
Also the chip is in some chess computers, but there is also no external ROM.
mit freundlichen Grüßen.
Ing. Robert Offner MSc.
Bob Andrews ***@***.***> schrieb am Fr., 20. Juni 2025, 17:13:
… *mrdudz* left a comment (cc65/cc65#2707)
<#2707 (comment)>
One odd thing is that "inc a" and "dec a" are right now swapped (in both
the assembler and the disassembler) - ie the documentation (that pdf) has
them the other way around than currently implemented. This seems to follow
the general logic of 6502 clones - however, we need to confirm whether this
is really correct for the m740.
not sure which PDF you're referring to. i found this, if it is helpful:
https://bitsavers.org/components/mitsubishi/melps/1989_Series_740_Software_Users_Manual.pdf
Thats the one, indeed. ***@***.*** <https://github.com/roberto314>
linked to it in #986It seems) weird the INC A/DEC A doesn't follow the
usual pattern.
@roberto314 <https://github.com/roberto314> did you find any other
software we could disassemble?
—
Reply to this email directly, view it on GitHub
<#2707 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AH6PK7RIDML7IWEVPQCOFD33EQQLNAVCNFSM6AAAAAB7L2K6FGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSOJRHE4DSMBXGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
OK, thanks anyway.... too bad :) So i'll merge it as is - we'll see |
Which opcode or opcodes are we talking about?
mit freundlichen Grüßen.
Ing. Robert Offner MSc.
Bob Andrews ***@***.***> schrieb am Fr., 20. Juni 2025, 19:39:
… Merged #2707 <#2707> into master.
—
Reply to this email directly, view it on GitHub
<#2707 (comment)>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AH6PK7XARUZ2ZJZOL27UXJD3ERBOTAVCNFSM6AAAAAB7L2K6FGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJYGI2TCNJUG4ZTQMY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
in the pdf $1a is "dec a", and $3a is "inc a" - however, that does not match the usual encoding scheme, which is why the assembler (and disassembler) currently uses $3a for "dec a" and $1a for "inc a". unfortunately the software you dumped does not contain either, so no way to even guess what is correct. can you actually run software on that thing for a test? should be easy to find out then :) |
I' ll think about it and get back to you.
mit freundlichen Grüßen.
Ing. Robert Offner MSc.
Bob Andrews ***@***.***> schrieb am Fr., 20. Juni 2025, 19:59:
… *mrdudz* left a comment (cc65/cc65#2707)
<#2707 (comment)>
Which opcode or opcodes are we talking about?
in the pdf $1a is "dec a", and $3a is "inc a" - however, that does not
match the usual encoding scheme, which is why the assembler (and
disassembler) currently uses $3a for "dec a" and $1a for "inc a".
unfortunately the software you dumped does not contain either, so no way to
even guess what is correct.
can you actually run software on that thing for a test? should be easy to
find out then :)
—
Reply to this email directly, view it on GitHub
<#2707 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AH6PK7QSBTEN2MNSPJ23PET3ERDY5AVCNFSM6AAAAAB7L2K6FGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSOJSGQYDGMJZGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
yes, the pdf in itself is consistent |
took #986 and made all opcodes work
Basic roundtrip (disassemble/assemble) works now. Some docs are missing. Some more cleanup is needed perhaps :)