8000 Build devnet with Cannon by guidanoli · Pull Request #164 · cartesi/dave · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Build devnet with Cannon #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 19, 2025
Merged

Build devnet with Cannon #164

merged 10 commits into from
May 19, 2025

Conversation

guidanoli
Copy link
Collaborator
@guidanoli guidanoli commented May 16, 2025 •
edited
Loading

This PR:

  • replaces Forge scripts with Cannonfiles
  • deploys an Application contract for Cartesi Rollups devnet
  • writes/reads the address of this Application contract to/from the addresses file
  • updates Cannon CLI from 2.21.5 to 2.22.0
  • updates Cartesi Rollups Contracts from 2.0.0-rc.17 to 2.0.0-rc.18
  • adds steps to CI to install pnpm and cache dependencies
  • removes dead code (Forge scripts, deploy_anvil.sh scripts, etc)

GCdePaula
GCdePaula reviewed May 16, 2025
View reviewed changes
Copy link
Collaborator
@GCdePaula GCdePaula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

@GCdePaula
Copy link
Collaborator

I'm also getting a few Rust compile errors on the tests, but it seems like very simple stuff to fix.

@guidanoli guidanoli force-pushed the feature/cannon-devnet branch 4 times, most recently from 258890b to e565ec6 Compare May 16, 2025 18:33
@guidanoli guidanoli force-pushed the feature/cannon-devnet branch from e565ec6 to bba04fb Compare May 16, 2025 19:07
@guidanoli guidanoli marked this pull request as ready for review May 16, 2025 19:24
@guidanoli guidanoli requested review from stephenctw and GCdePaula May 16, 2025 19:24
@guidanoli guidanoli force-pushed the feature/cannon-devnet branch from bba04fb to 4559de7 Compare May 16, 2025 20:07
GCdePaula
GCdePaula approved these changes May 16, 2025
View reviewed changes
Copy link
Collaborator
@GCdePaula GCdePaula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@guidanoli guidanoli merged commit 3bdf6a5 into main May 19, 2025
7 checks passed
@guidanoli guidanoli deleted the feature/cannon-devnet branch May 19, 2025 12:17
@guidanoli guidanoli mentioned this pull request May 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GCdePaula GCdePaula GCdePaula approved these changes

@stephenctw stephenctw Awaiting requested review from stephenctw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guidanoli @GCdePaula
0