feat(api): Add alert path prefix as configuration field #648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deadlycoconuts
commented
May 5, 2025
bthari
approved these changes
May 7, 2025
|
Thanks for the quick approval! Merging this now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot b
3067
e applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR simply introduces a new configuration field for the Merlin API server to make the alert path prefix (currently hardcoded as
alerts/merlin) into a configurable field. This allows for more customisable paths to be used when setting up alerts using the current GitOps approach.Modifications
api/config/config.go- Added a new configuration fieldAlertPathPrefixapi/service/model_endpoint_alert_service.go- Made changes to the current way an alert file path is generatedTests
Checklist
Release Notes