8000 feat(api): Decouple Arize and BigQuery sink config by naufalandika · Pull Request #630 · caraml-dev/merlin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(api): Decouple Arize and BigQuery sink config #630

New issue < 8000 /summary>

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 19, 2025
Merged

feat(api): Decouple Arize and BigQuery sink config #630

merged 2 commits into from
Feb 19, 2025

Conversation

naufalandika
Copy link
Contributor

Description

Use BigQuery sink as the sink default and add EnabledModelSerials config to ArizeSink to determine which model needs ArizeSink for the ObservationSinks config. The value for the EnabledModelSerials is following this pattern {Project}_{Model Name}_{Model Version}, separated with comma.

Modifications

Only add ArizeSink in the consumer config if the model serial is in the EnabledModelSerials

Tests

  1. Hit redeploy API locally while connected to staging env without OBSERVABILITYPUBLISHER_ARIZESINK_ENABLEDMODELSERIALS env, the config.yaml file generated for the consumer looks like this
observation_sinks:
- type: BIGQUERY
  config:
    project: p-gojek-data-science
    dataset: data_science_platform_playground
    ttl_days: 14
  1. Hit redeploy API locally while connected to staging env with "OBSERVABILITYPUBLISHER_ARIZESINK_ENABLEDMODELSERIALS": "tari-staging_pyfunc-play_3" , the config.yaml file generated for the consumer looks like this
observation_sinks:
- type: BIGQUERY
  config:
    project: p-gojek-data-science
    dataset: data_science_platform_playground
    ttl_days: 14
- type: ARIZE
  config:
    api_key: YzJjNmY5OGZhMGNmYTkxOTc0YQ==
    space_key: ODVkMmMwMg==

Checklist

  • Added PR label
  • Added unit test, integration, and/or e2e tests
  • Tested locally
  • Updated documentation
  • Update Swagger spec if the PR introduce API changes
  • Regenerated Golang and Python client if the PR introduces API changes
NONE

@naufalandika naufalandika added the enhancement New feature or request label Feb 18, 2025
@naufalandika naufalandika self-assigned this Feb 18, 2025
vinoth-gojek
vinoth-gojek approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor
@vinoth-gojek vinoth-gojek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! @naufalandika pls merge your changes after configurations are updated. Thank you!

@naufalandika naufalandika merged commit f947226 into main Feb 19, 2025
34 checks passed
@naufalandika naufalandika deleted the feat-arize-flag-config branch February 19, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinoth-gojek vinoth-gojek vinoth-gojek approved these changes

@bthari bthari Awaiting requested review from bthari

Assignees

@naufalandika naufalandika

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naufalandika @vinoth-gojek
0