8000 Cicd/sdk versioning improvement by andreas-aji · Pull Request #634 · caraml-dev/merlin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Cicd/sdk versioning improvement #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Mar 18, 2025
Merged

Cicd/sdk versioning improvement #634

merged 14 commits into from
Mar 18, 2025

Conversation

andreas-aji
Copy link
Contributor
@andreas-aji andreas-aji commented Mar 13, 2025 •
edited
Loading

Description

  • Background: we want to use latest merlin-sdk on batch-predictor and pyfunc-server. Previously we cannot do that because these packages relies on merlin-sdk versions that have been uploaded to PyPI. The idea is making the development and pipeline smoother by enabling these packages to install merlin-sdk from local source if the version is not yet available on pypi.

Modifications

  • Adjusted make setup in pyfunc-server and batch-predictor to always build and install merlin-sdk to have the latest version
  • Automate merlin-sdk version requirement to tag on pipeline (pypi release step)

Tests

  • Test github actions pipelines if it's working correctly.

Checklist

  • Added PR label
  • Added unit test, integration, and/or e2e tests
  • Tested locally
  • Updated documentation
  • Update Swagger spec if the PR introduce API changes
  • Regenerated Golang and Python client if the PR introduces API changes

@andreas-aji andreas-aji marked this pull request as draft March 13, 2025 10:48
@andreas-aji andreas-aji added the enhancement New feature or request label Mar 13, 2025
@andreas-aji andreas-aji marked this pull request as ready for review March 14, 2025 03:02
@andreas-aji andreas-aji changed the title draft: Cicd/sdk versioning improvement Cicd/sdk versioning improvement Mar 14, 2025
shydefoo
shydefoo reviewed Mar 18, 2025
View reviewed changes
Copy link
Contributor
@shydefoo shydefoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! Will leave it to ziyi/bthari to approve in case there are some stuff i may have missed out.

deadlycoconuts
deadlycoconuts approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor
@deadlycoconuts deadlycoconuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the changes @andreas-aji ! 🚀🙏 Just left one comment but everything LGTM!

@andreas-aji andreas-aji merged commit 2ce16a0 into main Mar 18, 2025
33 checks passed
@andreas-aji andreas-aji deleted the cicd/sdk-versioning-improvement branch March 18, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shydefoo shydefoo shydefoo left review comments

@deadlycoconuts deadlycoconuts deadlycoconuts approved these changes

@bthari bthari Awaiting requested review from bthari

Assignees

@andreas-aji andreas-aji

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreas-aji @shydefoo @deadlycoconuts
0