8000 Comparing v0.48.2...v0.48.3 · caraml-dev/merlin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: caraml-dev/merlin
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.48.2
Choose a base ref
...
head repository: caraml-dev/merlin
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.48.3
Choose a head ref
  • 4 commits
  • 15 files changed
  • 2 contributors

Commits on May 2, 2025

  1. fix(ui): add maxcompute support to job detail page (#644)

    <!--  Thanks for sending a pull request!  Here are some tips for you:
    
    1. Run unit tests and ensure that they are passing
    2. If your change introduces any API changes, make sure to update the
    e2e tests
    3. Make sure documentation is updated for your PR!
    
    -->
    # Description
    This PR will fix a bug on Batch Prediction Job Detail Page. Previously
    there was an error (`Something Went Wrong`) when opening this page. That
    can happen because this page doesn't support MaxCompute Sink & Source.
    <img width="1728" alt="image"
    src="https://github.com/user-attachments/assets/65218ea9-35a2-4872-b65a-ceadd654c374"
    />
    
    
    # Modifications
    - Add MaxCompute Sink & Source
    
    # Tests
    <!-- Besides the existing / updated automated tests, what specific
    scenarios should be tested? Consider the backward compatibility of the
    changes, whether corner cases are covered, etc. Please describe the
    tests and check the ones that have been completed. Eg:
    - [x] Deploying new and existing standard models
    - [ ] Deploying PyFunc models
    -->
    
    # Checklist
    - [x] Added PR label
    - [ ] Added unit test, integration, and/or e2e tests
    - [x] Tested locally
    - [ ] Updated documentation
    - [ ] Update Swagger spec if the PR introduce API changes
    - [ ] Regenerated Golang and Python client if the PR introduces API
    changes
    
    # Release Notes
    <!--
    Does this PR introduce a user-facing change?
    If no, just write "NONE" in the release-note block below.
    If yes, a release note is required. Enter your extended release note in
    the block below.
    If the PR requires additional action from users switching to the new
    release, include the string "action required".
    
    For more information about release notes, see kubernetes' guide here:
    http://git.k8s.io/community/contributors/guide/release-notes.md
    -->
    
    ```release-note
    NONE
    ```
    anantadwi13 authored May 2, 2025
    Configuration menu
    Copy the full SHA
    f4a0e68 View commit details
    Browse the repository at this point in the history
  2. feat(ui): update templating of monitoring url (#643)

    <!--  Thanks for sending a pull request!  Here are some tips for you:
    
    1. Run unit tests and ensure that they are passing
    2. If your change introduces any API changes, make sure to update the
    e2e tests
    3. Make sure documentation is updated for your PR!
    
    -->
    # Description
    In this PR, we are moving the templating of monitoring url from classic
    string concat to [mustache
    template](https://github.com/janl/mustache.js). This change allows user
    to configure the monitoring url dynamically without being constrained by
    our pre-defined url format
    
    # Modifications
    - add new mustache dependency
    - update `createMonitoringUrl` logic to use mustache template
    - remove duplicated code of `createMonitoringUrl`
    
    # Tests
    <!-- Besides the existing / updated automated tests, what specific
    scenarios should be tested? Consider the backward compatibility of the
    changes, whether corner cases are covered, etc. Please describe the
    tests and check the ones that have been completed. Eg:
    - [x] Deploying new and existing standard models
    - [ ] Deploying PyFunc models
    -->
    
    # Checklist
    - [x] Added PR label
    - [ ] Added unit test, integration, and/or e2e tests
    - [x] Tested locally
    - [ ] Updated documentation
    - [ ] Update Swagger spec if the PR introduce API changes
    - [ ] Regenerated Golang and Python client if the PR introduces API
    changes
    
    # Release Notes
    <!--
    Does this PR introduce a user-facing change?
    If no, just write "NONE" in the release-note block below.
    If yes, a release note is required. Enter your extended release note in
    the block below.
    If the PR requires additional action from users switching to the new
    release, include the string "action required".
    
    For more information about release notes, see kubernetes' guide here:
    http://git.k8s.io/community/contributors/guide/release-notes.md
    -->
    
    ```release-note
    There will be a breaking change for the next released version. Users need to update
    REACT_APP_MONITORING_DASHBOARD_JOB_BASE_URL env var to use the latest format.
    ```
    anantadwi13 authored May 2, 2025
    Configuration menu
    Copy the full SHA
    6a9d268 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2025

  1. fix(ui): revert changes in Job constructor (#647)

    # Description
    This PR reverts changes related to `Job` constructor in this PR
    #644. We should not change the
    `Job` constructor unless we want to support `Job` creation using
    MaxCompute. This PR also contains a bug fix related to wrong field name
    in `JobRunPanel`
    
    # Tests
    <!-- Besides the existing / updated automated tests, what specific
    scenarios should be tested? Consider the backward compatibility of the
    changes, whether corner cases are covered, etc. Please describe the
    tests and check the ones that have been completed. Eg:
    - [x] Deploying new and existing standard models
    - [ ] Deploying PyFunc models
    -->
    
    # Checklist
    - [x] Added PR label
    - [ ] Added unit test, integration, and/or e2e tests
    - [x] Tested locally
    - [ ] Updated documentation
    - [ ] Update Swagger spec if the PR introduce API changes
    - [ ] Regenerated Golang and Python client if the PR introduces API
    changes
    
    # Release Notes
    ```release-note
    NONE
    ```
    anantadwi13 authored May 5, 2025
    Configuration menu
    Copy the full SHA
    b7a429d View commit details
    Browse the repository at this point in the history

Commits on May 7, 2025

  1. feat(api): Add alert path prefix as configuration field (#648)

    # Description
    This PR simply introduces a new configuration field for the Merlin API
    server to make the alert path prefix (currently hardcoded as
    `alerts/merlin`) into a configurable field. This allows for more
    customisable paths to be used when setting up alerts using the current
    GitOps approach.
    
    # Modifications
    - `api/config/config.go` - Added a new configuration field
    `AlertPathPrefix`
    - `api/service/model_endpoint_alert_service.go` - Made changes to the
    current way an alert file path is generated
    
    # Tests
    <!-- Besides the existing / updated automated tests, what specific
    scenarios should be tested? Consider the backward compatibility of the
    changes, whether corner cases are covered, etc. Please describe the
    tests and check the ones that have been completed. Eg:
    - [x] Deploying new and existing standard models
    - [ ] Deploying PyFunc models
    -->
    
    # Checklist
    - [x] Added PR label
    - [x] Added unit test, integration, and/or e2e tests
    - [x] Tested locally
    - [ ] Updated documentation
    - [ ] Update Swagger spec if the PR introduce API changes
    - [ ] Regenerated Golang and Python client if the PR introduces API
    changes
    
    # Release Notes
    <!--
    Does this PR introduce a user-facing change?
    If no, just write "NONE" in the release-note block below.
    If yes, a release note is required. Enter your extended release note in
    the block below.
    If the PR requires additional action from users switching to the new
    release, include the string "action required".
    
    For more information about release notes, see kubernetes' guide here:
    http://git.k8s.io/community/contributors/guide/release-notes.md
    -->
    
    ```release-note
    NONE
    ```
    deadlycoconuts authored May 7, 2025
    Configuration menu
    Copy the full SHA
    256b2f9 View commit details
    Browse the repository at this point in the history
Loading
0