8000 Add PSBT tests to fees-package by Legend101Zz · Pull Request #304 · caravan-bitcoin/caravan · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add PSBT tests to fees-package #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 34 commits into from
Jun 13, 2025
Merged

Add PSBT tests to fees-package #304

merged 34 commits into from
Jun 13, 2025

Conversation

Legend101Zz
Copy link
Contributor

Purpose:
To validate that the fees-package correctly generates updated PSBTs for both RBF and CPFP when provided with valid input data.

What’s included:

  • Added test cases and fixtures to cover RBF and CPFP logic
  • Included necessary patches to support the testing flow
  • Ensured the output PSBTs reflect the expected modifications when valid information is provided

@changeset-bot changeset-bot
Copy link
changeset-bot bot commented Jun 6, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 7b01212

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@caravan/fees Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link
vercel bot commented Jun 6, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
caravan-coordinator ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2025 8:03pm

bucko13
bucko13 requested changes Jun 8, 2025
View reviewed changes
Copy link
Contributor
@bucko13 bucko13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great additions! mostly just small questions and comments. I think the biggest one is probably being more specific with the derivations type when dealing with inputs.

@Legend101Zz Legend101Zz added fee-bumping related to adding support for fee bumping utilities and @caravan/fees @caravan/fees ready for review labels Jun 8, 2025
@Legend101Zz Legend101Zz requested a review from bucko13 June 13, 2025 18:15
bucko13
bucko13 reviewed Jun 13, 2025
View reviewed changes
bucko13
bucko13 reviewed Jun 13, 2025
View reviewed changes
bucko13
bucko13 requested changes Jun 13, 2025
View reviewed changes
Copy link
Contributor
@bucko13 bucko13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just need to make sure the getters and setters use consistent casing and then we're good to go!

@Legend101Zz Legend101Zz requested a review from bucko13 June 13, 2025 20:02
@bucko13 bucko13 enabled auto-merge (squash) June 13, 2025 20:07
bucko13
bucko13 approved these changes Jun 13, 2025
View reviewed changes
Copy link
Contributor
@bucko13 bucko13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@bucko13 bucko13 merged commit c583667 into caravan-bitcoin:main Jun 13, 2025
4 checks passed
This was referenced Jun 13, 2025
Merged
Open
Open
Legend101Zz added a commit to Legend101Zz/caravan that referenced this pull request Jun 18, 2025
@Legend101Zz
merge : RBF changes into this branch that were taken out and merged i…
1182854 
…n a seperate PR caravan-bitcoin#304
This was referenced Jun 1, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bucko13 bucko13 bucko13 approved these changes

Assignees
No one assigned
Labels
@caravan/fees fee-bumping related to adding support for fee bumping utilities and @caravan/fees ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Legend101Zz @bucko13
0