8000 simple toString method by scottf-tvw · Pull Request #66 · captioning/captioning · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

simple toString method #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

simple toString method #66

wants to merge 2 commits into from

Conversation

scottf-tvw
Copy link

skip file system saving in order to return webvtt formatted string

@scottf-tvw
add toString
54a3a81 
skip file system saving in order to return webvtt string from
webservice call
@scottf-tvw
set error count to one, temp fix for 2 blank lines at the end of VTT
1ac6741
@peter279k
Copy link

This PR has some issues that need to be resolved.

  • The PR has the file conflicts and it should be resolved.
  • The Travis CI build is failed due to failed assertions. They should be checked and resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottf-tvw @peter279k
0