comparing across same datatype, different length #411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rhaffar thanks for flagging and fixing. LGTM |
fdosani
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snowflake/Snowpark datatypes can vary by length - additionally, string representation of those types bakes in these variances. Updating comparisons to compare directly on types to allow for comparing same types with different lengths/precisions.
The datatype returned by
field.datatypeis actually an instance of a datatype class which bakes in length/precision, which is why we compare on the type of the datatype field. We use the datatype field to call thesimple_stringinstance method to get a string representation of the datatype, and the type of the datatype field for actual comparison.All Snowflake tests passing.