ArrayPtr-based AsyncInputStream::read() #2319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bb214d9 to
9b85e7c
Compare
kentonv
reviewed
Jun 11, 2025
kentonv
reviewed
Jun 11, 2025
45571a8 to
8ce9427
Compare
mikea
added a commit
to cloudflare/workerd
that referenced
this pull request
Jun 11, 2025
The method becomes non-virtual in capnproto/capnproto#2319 We can remove the override now.
mikea
added a commit
to cloudflare/workerd
that referenced
this pull request
Jun 11, 2025
The method becomes non-virtual in capnproto/capnproto#2319 We can remove the override now.
8ce9427 to
df5e600
Compare
mikea
commented
Jun 16, 2025
| @@ -1791,7 +1791,7 @@ private: | |||
| maxBytes = kj::min(maxBytes, MAX_CHUNK_HEADER_SIZE); | |||
| } | |||
|
|
|||
| readPromise = inner.read(headerBuffer.begin() + bufferEnd, 1, maxBytes); | |||
| readPromise = inner.read(headerBuffer.slice(bufferEnd).first(maxBytes).asBytes(), 1); | |||
There was a problem hiding this comment.
I think this is the only non-trivial change.
kentonv
approved these changes
Jun 16, 2025
df5e600 to
ff6ec3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.