[breaking] Reimplement global conventions #877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d8f1fa6 to
746837b
Compare
|
@castwide - how far away do you think this one? I'm thinking through upcoming releases of solargraph-rails. I'm guessing solargraph-rails should pin to a solargraph <0.53.0 until then, yeah? |
This was referenced May 25, 2025
I'm picking this back up and hoping to get it into a release sometime this month. |
2352b70 to
883025c
Compare
apiology
reviewed
Jun 24, 2025
Co-authored-by: Vince Broz <vince@broz.cc>
This was referenced Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in a comment in #781, the switch from
YardMaptoDocMapblocked processing of global conventions. We need a way forward for plugins that depend on it. The proposal here is thatConvention::Base#globalaccept aDocMapargument. Plugins that expect aYardMapwill need to be updated accordingly.