add --show=name,email
#108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
In this PR, I took the approach of being minimally invasive and simply extending the patterns of the existing behavior. I'd much prefer to do a refactor of the logic to extract functions and classes to model the approach instead of using logic branches (if/else blocks) and flags, but I wouldn't want to invest that time unless I had some maintenance stake in the project. |
|
Thanks! Please ping me again here if I don't review in the next few days... |
|
@casperdcl Thanks for the offer of review. Let me know if you have any questions. |
|
@casperdcl Friendly bump. Let me know if this is something that's potentially to be accepted. Thanks! |
415e26c to
954e642
Compare
|
/tag v2.2.0 6c3311c |
|
Excellent! Love the improvements. Thanks for reviewing, merging, and releasing! |
Closes #96
Summary
Instead of gathering just the names during the main loop, the routine now gathers both the names and emails, and then depending on which flags were elected, perhaps only the names or only the emails will be rendered. Perhaps this behavior could be made the default, but for backward compatibility, it's an opt-in behavior for now.