-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: add casdoor as saml idp support #571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 0x2a <stevesough@gmail.com>
Signed-off-by: 0x2a <stevesough@gmail.com>
@seriouszyx @Abingcbc @ComradeProgrammer please review |
@seriouszyx plz review |
nice work! |
Signed-off-by: Steve0x2a <stevesough@gmail.com>
Signed-off-by: Steve0x2a <stevesough@gmail.com>
Signed-off-by: Steve0x2a <stevesough@gmail.com>
Signed-off-by: Steve0x2a <stevesough@gmail.com>
Signed-off-by: Steve0x2a <stevesough@gmail.com>
Signed-off-by: Steve0x2a <stevesough@gmail.com>
Signed-off-by: Steve0x2a <stevesough@gmail.com>
Signed-off-by: Steve0x2a <stevesough@gmail.com>
@seriouszyx plz review |
hsluoyz
requested changes
Apr 7, 2022
web/src/auth/LoginPage.js
Outdated
const link = Setting.getFromLink(); | ||
Setting.goToLink(link); | ||
} else if (responseType === "code") { | ||
const code = res.data; | ||
const concatChar = oAuthParams?.redirectUri?.includes('?') ? '&' : '?'; | ||
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no change
Signed-off-by: Steve0x2a <stevesough@gmail.com>
hsluoyz
approved these changes
Apr 8, 2022
🎉 This PR is included in version 1.38.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
deancn
added a commit
to airdb/casdoor
that referenced
this pull request
Apr 17, 2022
* up/master: (188 commits) feat: try to support custom OAuth provider (casdoor#667) feat: add isProfilePublic setting for accessing user info (casdoor#656) Improve resource DB column length. fix: cicd error (casdoor#671) feat: add wechat mini program support (casdoor#658) fix: add independent error message in token endpoint (casdoor#662) feat: implement proxy (casdoor#661) feat: implement CAS 3.0 (casdoor#659) feat: add casdoor as saml idp support (casdoor#571) fix: grantTypes undefined err (casdoor#654) fix: link type error (casdoor#653) feat: support user migration from Keycloak using syncer (casdoor#645) Enable extra pages. fix: sign In button in the result page has broken (casdoor#646) fix: change goth version (casdoor#644) feat: support CAS with organizations and applications (casdoor#621) fix: token endpoint supports json format (casdoor#641) feat: add Alipay support as idp (casdoor#638) fix: qq idp missing username (casdoor#636) Init DB only when necessary. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it is necessary to perform sp connection test, so it is set to draft state
Signed-off-by: 0x2a stevesough@gmail.com
Fix: #405