8000 Add EnforceWithMatcher method by nodece · Pull Request #283 · casbin/casbin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add EnforceWithMatcher method #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2019
Merged

Add EnforceWithMatcher method #283

merged 1 commit into from
Sep 3, 2019

Conversation

nodece
Copy link
Member
@nodece nodece commented Sep 2, 2019

Add EnforceWithMatcher method for casbin/casbin-server#21

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 73.843% when pulling 5a306a6 on nodece:master into 060f042 on casbin:master.

@hsluoyz
Copy link
Member
hsluoyz commented Sep 2, 2019

Can we avoid modifying Enforce()?

@nodece
Copy link
Member Author
nodece commented Sep 2, 2019

@hsluoyz Do you have any good suggestions?

@hsluoyz
Copy link
Member
hsluoyz commented Sep 3, 2019

Define a new function and replace the matcher in it.

@nodece
Copy link
Member Author
nodece commented Sep 3, 2019

Define a new function and replace the matcher in it.

Model matcher should not be replaced, I think enforce should allow custom matcher.

@hsluoyz hsluoyz merged commit 8d5c748 into casbin:master Sep 3, 2019
@hsluoyz
Copy link
Member
hsluoyz commented Sep 3, 2019

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0