fix: wrong type of locking #1061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tangyang9464 please review |
7beac0e to
16cb80e
Compare
| @@ -131,8 +131,8 @@ func (e *SyncedEnforcer) LoadIncrementalFilteredPolicy(filter interface{}) error | |||
|
|
|||
| // SavePolicy saves the current policy (usually after changed with Casbin API) back to file/database. | |||
| func (e *SyncedEnforcer) SavePolicy() error { | |||
| e.m.RLock() | |||
| defer e.m.RUnlock() | |||
| e.m.Lock() | |||
There was a problem hiding this comment.
Will there be a race in SavePolicy, I think it just reads the resource
There was a problem hiding this comment.
Saving policies cause the adapter to write to, i.e., a database.
A RemovePolicy() and the SavePolicy will emit concurrent database writes.
There was a problem hiding this comment.
The adapter itself should ensure transaction security, but it seems that it does not now, it can only be locked here
|
🎉 This PR is included in version 2.51.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SavePolicy()should require the lock for RW.