8000 feat: keyMatch5 for ignoring params in url by Abingcbc · Pull Request #910 · casbin/casbin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: keyMatch5 for ignoring params in url #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2021
Merged

feat: keyMatch5 for ignoring params in url #910

merged 1 commit into from
Nov 2, 2021

Conversation

Abingcbc
Copy link
Member
@Abingcbc Abingcbc commented Oct 28, 2021

Fix: #909

What problem does this PR solve?

Add KeyMatch5 to ignoring params in URL when matching keys.

Related Issue: #909

What is changed and how it works?

Add a new operation keyMatch5

Check List

Tests

Unit test

Code changes

Has exported function/method change

@casbin-bot
Copy link
Member

@tangyang9464 @closetool @sagilio please review

@hsluoyz
Copy link
Member
hsluoyz commented Oct 28, 2021

@francohandel plz review

Signed-off-by: abingcbc <abingcbc626@gmail.com>
@hsluoyz hsluoyz mentioned this pull request Oct 28, 2021
@hsluoyz
Copy link
Member
hsluoyz commented Nov 1, 2021

@francohandel plz review

@hsluoyz hsluoyz merged commit 596067b into casbin:master Nov 2, 2021
@github-actions
Copy link
github-actions bot commented Nov 2, 2021

🎉 This PR is included in version 2.39.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@francohandel
Copy link

@Abingcbc i just finished reviewing the feature and i think you really did a great job. thanks for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[KeyMatch5:Matcher to match URLs with query params of restful paths]
4 participants
0