8000 feat: add updatefilteredpolicies by kilosonc · Pull Request #732 · casbin/casbin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add updatefilteredpolicies #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2021
Merged

feat: add updatefilteredpolicies #732

merged 1 commit into from
Apr 17, 2021

Conversation

kilosonc
Copy link
Contributor
@kilosonc kilosonc commented Mar 11, 2021 •
edited by hsluoyz
Loading

Signed-off-by: closetool c299999999@qq.com

Fix: #728

Fix: #731

@hsluoyz
Copy link
Member
hsluoyz commented Mar 11, 2021

@arafat-java @dahu33 plz review.

nodece
nodece reviewed Mar 13, 2021
View reviewed changes
nodece
nodece reviewed Mar 13, 2021
View reviewed changes
nodece
nodece reviewed Mar 13, 2021
View reviewed changes
@hsluoyz hsluoyz mentioned this pull request Mar 18, 2021
Closed
dahu33
dahu33 suggested changes Mar 18, 2021
View reviewed changes
Copy link
Contributor
@dahu33 dahu33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great but I believe the current adapter API cannot preserve atomicity, please see my comment.

@kilosonc
feat: add updatefilteredpolicies
e3538fb 
Signed-off-by: closetool <c299999999@qq.com>
@kilosonc
Copy link
Contributor Author
kilosonc commented Apr 9, 2021

@hsluoyz @dahu33 changed, plz reuview

@hsluoyz hsluoyz merged commit 2d182bf into casbin:master Apr 17, 2021
@github-actions
Copy link

🎉 This PR is included in version 2.28.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@hsluoyz hsluoyz mentioned this pull request Apr 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dahu33 dahu33 dahu33 requested changes

@hsluoyz hsluoyz hsluoyz left review comments

@nodece nodece nodece left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Wipe all the existing policies on an object, and then set them to whatever is passed afresh Stronger UpdatePolicies() API
4 participants
@kilosonc @hsluoyz @dahu33 @nodece
0