10000 submodules/grpc: Update grpc submodule branch by townsend2010 · Pull Request #1182 · canonical/multipass · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

submodules/grpc: Update grpc submodule branch #1182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jan 9, 2020
Merged

submodules/grpc: Update grpc submodule branch #1182

merged 12 commits into from
Jan 9, 2020

Conversation

townsend2010
Copy link
Contributor

No description provided.

@multipass-ci-bot

This comment has been minimized.

Sign in to view
@ricab
Copy link
Collaborator
ricab commented Nov 29, 2019

Hey @townsend2010 , just to let you know I tried this to see if it would help fix the debug-build failure in disco and I got earlier errors there (in boringssl). Those appeared in both debug and release.

In both cases the problems are caused by warnings that are promoted to errors (I guess the compiler is more thorough). I wonder if we should disable that in 3rd party stuff, since it is out of our reach...

@multipass-ci-bot

This comment has been minimized.

Sign in to view
@townsend2010 townsend2010 mentioned this pull request Jan 6, 2020
Closed
Chris Townsend and others added 10 commits January 8, 2020 15:25
@ricab
submodules/grpc: Update grpc submodule branch
bf1cb54
@ricab
[cmake] Accept new warnings from boringssl
83e510a 
Allow ignored-qualifier warnings, to fix building failure in biomem.cpp,
due to included boringssl headers.
@ricab
[cmake] Simplify setting of warning options
< 8000 span class="Skeleton d-inline-block" style="width:12px; height:12px;">
825011a
@ricab
[test] Fix warnings when optimization is turned on
1e6ac98 
Even just -Og makes gcc issue a warning about uninitialized vars that
would not appear otherwise. See https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wmaybe-uninitialized
@ricab
[test] Get rid of maybe-uninitialized warning
44c4ac0 
Bypasses what I believe is a gcc bug, making it issue a very strange
warning when a `mp::ProcessState` is captured by value in a certain
lambda and optimization is turned on (at least -Og).
@ricab
[cov] Apply coverage options to third party too
0789c6d
@ricab
[cov] Let GCC decide what coverage means
0008e8e 
Fixes cmake policy warning.
@ricab
[cov] Refuse coverage unless using GCC
9774ead
@ricab
[cov] Fix linker option in older cmake versions
c740373
@ricab
Merge branch 'mute-new-werror' into update-grpc
cc1f9ce
@multipass-ci-bot

This comment has been minimized.

Sign in to view
@codecov-io
Copy link
codecov-io commented Jan 8, 2020 •
edited by codecov bot
Loading

Codecov Report

Merging #1182 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1182   +/-   ##
=======================================
  Coverage   71.47%   71.47%           
=======================================
  Files         203      203           
  Lines        7506     7506           
=======================================
  Hits         5365     5365           
  Misses       2141     2141

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff85ac3...8c609d6. Read the comment docs.

@townsend2010
Copy link
Contributor Author

Even though this was originally my PR, the work needed to get the coverage building was done by @ricab, so I'll review this 😁

@ricab
Copy link
Collaborator
ricab commented Jan 9, 2020

@townsend2010 hey, just a heads-up that I had to force-push to fix a wrong comment.

@multipass-ci-bot
Copy link
Collaborator
multipass-ci-bot commented Jan 9, 2020 •
edited
Loading

macOS build available: multipass-1.1.0-dev.549+g7a5281cb.mac-Darwin.pkg
Snap build available: snap refresh multipass --channel edge/pr1182

townsend2010
townsend2010 commented Jan 9, 2020
View reviewed changes
Copy link
Contributor Author
@townsend2010 townsend2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, works. Windows build just need the updated yasm assembler and I'll address that in a separate PR.

I can't approve my own PR, so @ricab, would you do the honors please?

@ricab
Copy link
Collaborator
ricab commented Jan 9, 2020

OK, thanks @townsend2010.

bors r+

bors bot added a commit that referenced this pull request Jan 9, 2020
@bors @ricab
Merge #1182
79a966d 
1182: submodules/grpc: Update grpc submodule branch r=ricab a=townsend2010



Co-authored-by: Chris Townsend <christopher.townsend@canonical.com>
Co-authored-by: Ricardo Abreu <ricab@ricabhome.org>
@bors
Copy link
Contributor
bors bot commented Jan 9, 2020

Build succeeded

@bors bors bot merged commit 8c609d6 into master Jan 9, 2020
@bors bors bot deleted the update-grpc branch January 9, 2020 15:50 7245
@ricab ricab restored the update-grpc branch January 9, 2020 16:45
@ricab ricab deleted the update-grpc branch January 9, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@townsend2010 @multipass-ci-bot @ricab @codecov-io
0