Queues: option for no errors #1779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into fifo-better-testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It occurred to me that our 100-long commands list is not very useful if we can error out because of under- or overflow pretty early on.
This PR makes all the code -- the eDSL and the oracles -- resistant to errors. The underlying queues may still raise errors when underflow or overflow occurs, but the runner loop knows that it should ignore these and keep going until it is out of commands.
A side effect of this is a little neatening in data-generation. Earlier, I was "rigging" the random inputs with a small number (5%) of
pushcommands early on, just to make sure that the queue would not be hit with a straypoporpeekearly on, underflow, and thus quickly end the experiment.This work did reveal two bugs in my oracle code:
hotwas not being swapped over correctly after apop.