10000 updated deps by scopatz · Pull Request #1313 · cyclus/cyclus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

updated deps #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2016
Merged

updated deps #1313

merged 1 commit into from
Nov 16, 2016

Conversation

scopatz
Copy link
Member
@scopatz scopatz commented Nov 16, 2016

No description provided.

#. python3-numpy
#. python3-nose
#. python3-jinja2
#. cython3

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we refer also to python2-xxx ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for some not careful users, it might mess up their installation....

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not. This is a fully valid install and apt should not mess up anyone's system with this. Also, I am pretty sure that on newer versions of ubuntu python3 is the default, not python2

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ubuntu 16 has python2 as the default, so this set of dependencies will not work. I have demonstrated that it will not work.

If we remove the 3, it might (??) work on all systems because it will get the appropriate version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the default version depends on whether you are on ubuntu server or not: https://wiki.ubuntu.com/XenialXerus/ReleaseNotes

Removing the 3 will go to the Python 2 version, but on some level it is up to the user to know whether they want the binding to 2 or 3. If you are using the 3 interpreter, the 2 packages won't help. Maybe they could be listed as "python3-numpy or python-numpy"

@bam241
Copy link
Member
bam241 commented Nov 16, 2016

thx @scopatz

@bam241 bam241 merged commit 1d3580d into cyclus:develop Nov 16, 2016
@scopatz scopatz deleted the deps branch November 16, 2016 17:23
@gonuke
Copy link
Member
gonuke commented Nov 18, 2016

Sorry that I missed this in review, but can we also add the optional entries to the apt-get example, either in the existing apt-get example, or by adding a second one that includes all the optional dependencies. I think @Baaaaam will PR this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0