-
Notifications
You must be signed in to change notification settings - Fork 71
updated deps #1313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated deps #1313
Conversation
#. python3-numpy | ||
#. python3-nose | ||
#. python3-jinja2 | ||
#. cython3 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we refer also to python2-xxx ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for some not careful users, it might mess up their installation....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather not. This is a fully valid install and apt should not mess up anyone's system with this. Also, I am pretty sure that on newer versions of ubuntu python3 is the default, not python2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ubuntu 16 has python2 as the default, so this set of dependencies will not work. I have demonstrated that it will not work.
If we remove the 3
, it might (??) work on all systems because it will get the appropriate version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the default version depends on whether you are on ubuntu server or not: https://wiki.ubuntu.com/XenialXerus/ReleaseNotes
Removing the 3 will go to the Python 2 version, but on some level it is up to the user to know whether they want the binding to 2 or 3. If you are using the 3 interpreter, the 2 packages won't help. Maybe they could be listed as "python3-numpy or python-numpy"
thx @scopatz |
Sorry that I missed this in review, but can we also add the optional entries to the |
No description provided.