python: Suppress deprecation warnings related to OptionInfo #12009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aniemetz
reviewed
Jun 24, 2025
| extra_compile_args = [ | ||
| "-std=c++17", | ||
| "-fno-var-tracking", | ||
| # Suppress deprecation warnings for deprecated members of OptionInfo |
There was a problem hiding this comment.
Hm, until now we haven't suppressed these warnings in the Python API, but one may argue that this is the devs' business to take care of, not the users'. This in not only because of OptionInfo, is it?
There was a problem hiding this comment.
Yes, it is only because of OptionInfo. This case is special in the sense that we are still using OptionInfo, which contains deprecated members in its data structure. All other cases of deprecation warnings are related to functions that we no longer use.
8000
aniemetz
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #11931 introduced deprecation warnings for users of the cvc5 library. This PR suppresses those warnings when building the Python bindings for cvc5.