8000 Test autosaving of gamma correction setting by archibald1418 · Pull Request #9124 · cvat-ai/cvat · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Test autosaving of gamma correction setting #9124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
8000 Merged
merged 12 commits into from
Feb 24, 2025
Merged

Test autosaving of gamma correction setting #9124

merged 12 commits into from
Feb 24, 2025

Conversation

archibald1418
Copy link
Contributor
@archibald1418 archibald1418 commented Feb 19, 2025 •
edited
Loading

Update existing local storage test to include gamma setting checks.

Motivation and context

This is a test for storing gamma correction value alongside other settings inside localStorage.
Thanks to #9032, gamma is treated separately from other color settings. Unlike brightness, contrast and saturation settings, which change style attributes on #cvat_canvas_background, gamma is stored inside localStorage.clientSettings.imageFilter entity. This was the main motivation of updating the case_68_saving_settings_local_storage.js instead of writing a new testcase or updating the color settings test.

How has this been tested?

The main flow of the test stayed the same, but with couple of changes. Validation and setup parts were extended to include gamma.

Before the changes the test looked like this:

  1. Open job
  2. Setup workspace settings (check the boxes). Make sure that localStorage is set
  3. Reload
  4. Validate settings (should be checked)
  5. Repeat step 1 (this time uncheck the boxes)
  6. Reload
  7. Repeat step 3 (should be unchecked)

Now, gamma is set up before step 1 and validated after first reload. Also, color settings are reset after the gamma check to keep integrity between tests

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@codecov-commenter
Copy link
codecov-commenter commented Feb 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.16%. Comparing base (4f3bc10) to head (b0639d4).

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #9124      +/-   ##
===========================================
- Coverage    73.18%   73.16%   -0.03%     
===========================================
  Files          446      446              
  Lines        45661    45661              
  Branches      3907     3907              
===========================================
- Hits         33418    33408      -10     
- Misses       12243    12253      +10
Components Coverage Δ
cvat-ui 77.04% <ø> (-0.05%) ⬇️
cvat-server 70.04% <ø> (ø)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@archibald1418 archibald1418 merged commit 09bfb2a into develop Feb 24, 2025
34 checks passed
@archibald1418 archibald1418 deleted the ov/test-gamma branch February 25, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klakhov klakhov klakhov approved these changes

@bsekachev bsekachev Awaiting requested review from bsekachev bsekachev is a code owner

Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@archibald1418 @codecov-commenter @klakhov
0