Fix zip handling of osx hidden dirs #9571
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
8000
Learn more about bidirectional Unicode characters
It looks like zip files sometimes (always?) get categorized as 'archive' and are handled by the ArchiveReader rather than the ZipReader. Add osx hidden dir checking to ArchiveReader as well.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
It looks like zip files sometimes (always?) get categorized as 'archive' and are handled by the ArchiveReader rather than the ZipReader. Add osx hidden dir checking to ArchiveReader as well.
This is done through ArchiveReader's parent class DirectoryReader for ease of implementation. I can't think of a reason why we wouldn't want to ignore these dirs; so at best we catch junk directories that could show up in other archive types and at worst there's a small overhead of string comparisons.
How has this been tested?
I didn't see any existing tests of ZipReader's filtering logic and I didn't see an easy way to add a test for this. I tested these changes locally in a running server and verified an osx compressed archive gets processed to all expected images. Also verified there's no regressions in existing tests.
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.