8000 Add support for default bucket prefix and ability to search for files by Marishka17 · Pull Request #6943 · cvat-ai/cvat · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add support for default bucket prefix and ability to search for files #6943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Oct 24, 2023
Merged

Add support for default bucket prefix and ability to search for files #6943

merged 24 commits into from
Oct 24, 2023

Conversation

Marishka17
Copy link
Contributor
@Marishka17 Marishka17 commented Oct 5, 2023 •
edited
Loading

Motivation and context

Screenshot from 2023-10-09 10-49-33

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@Marishka17
Copy link
Contributor Author

/check

@github-actions
Copy link
Contributor
github-actions bot commented Oct 5, 2023 •
edited
Loading

❌ Some checks failed
📄 See logs here

@Marishka17
Copy link
Contributor Author

/check

@github-actions
Copy link
Contributor
github-actions bot commented Oct 9, 2023 •
edited
Loading

✔️ All checks completed successfully
📄 See logs here

@Marishka17 Marishka17 marked this pull request as ready for review October 12, 2023 10:16
klakhov
klakhov reviewed Oct 12, 2023
View reviewed changes
Copy link
Contributor
@klakhov klakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I set some default prefix, and then try to search for something else, with another prefix which I set with search input, what prefix would be used?

sizov-kirill
sizov-kirill reviewed Oct 12, 2023
View reviewed changes
SpecLad
SpecLad reviewed Oct 12, 2023
View reviewed changes
8000
@codecov
Copy link
codecov bot commented Oct 16, 2023 •
edited
Loading

Codecov Report

Merging #6943 (e815f26) into develop (b450b44) will decrease coverage by 0.32%.
Report is 24 commits behind head on develop.
The diff coverage is 67.85%.

@@             Coverage Diff             @@
##           develop    #6943      +/-   ##
===========================================
- Coverage    82.59%   82.28%   -0.32%     
===========================================
  Files          360      361       +1     
  Lines        38926    39200     +274     
  Branches      3570     3587      +17     
===========================================
+ Hits         32150    32254     +104     
- Misses        6776     6946     +170
Components Coverage Δ
cvat-ui 77.28% <83.33%> (-0.33%) ⬇️
cvat-server 86.87% <66.66%> (-0.30%) ⬇️

@Marishka17
Copy link
Contributor Author

If I set some default prefix, and then try to search for something else, with another prefix which I set with search input, what prefix would be used?

@klakhov, It depends on the intersection between the default prefix and the specified search prefix. If the default prefix includes the second one then the default prefix will be used otherwise the prefix from the search input will be used.

@klakhov
Copy link
Contributor
klakhov commented Oct 19, 2023

@bsekachev
It seems youve added alert for non-intersecting prefixes, but I suppose its not working as expected. My default prefix is hello/ and when Im trying to search for something like qqq from root I see no warning. Search string is not included in default prefix in such case.
image

image

@bsekachev
Copy link
Member
bsekachev commented Oct 19, 2023 •
edited
Loading

@klakhov

It is expected from parent directory because you never see files other then specified in prefix.
Meaning, that searching in parent directories does not make sense, always only one file is available

@bsekachev bsekachev merged commit 55a22e1 into develop Oct 24, 2023
@bsekachev bsekachev deleted the mk/add_aws_s3_prefix_support branch October 24, 2023 11:18
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Oct 25, 2023
@Marishka17 @mikhail-treskin
Add support for default bucket prefix and ability to search for files (…
75173f3 
…cvat-ai#6943)
@Marishka17 Marishka17 mentioned this pull request Oct 30, 2023
Merged
3 tasks
nmanovic pushed a commit that referenced this pull request Nov 2, 2023
@Marishka17
REST API tests for default bucket prefix (#7079)
1f8d5d3 
This PR contains REST API tests for #6943
@cvat-bot cvat-bot bot mentioned this pull request Nov 3, 2023
Merged
bsekachev pushed a commit that referenced this pull request Nov 6, 2023
@Marishka17 @bsekachev
REST API tests for default bucket prefix (#7079)
04146e1 
This PR contains REST API tests for #6943
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpecLad SpecLad SpecLad left review comments

@sizov-kirill sizov-kirill sizov-kirill left review comments

@klakhov klakhov klakhov approved these changes

@azhavoro azhavoro Awaiting requested review from azhavoro

@bsekachev bsekachev Awaiting requested review from bsekachev bsekachev is a code owner

@nmanovic nmanovic Awaiting requested review from nmanovic nmanovic is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Marishka17 @klakhov @bsekachev @SpecLad @sizov-kirill
0