tests: stop using libcurl's strdup #17297
Closed
+1
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not provided as a curlx function so should not be used outside of libcurl. I strongly suspect that no system we build the test suite on lack strdup so this will not cause any harm.
It's POSIX so I think you're right. Curl_wcsdup needs to be dealt with but it looks like just dropping it or setting to NULL is enough since wcsdup isn't used in the test code. |
|
Analysis of PR #17297 at aa5ce58e: Test 637 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Test 640 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Generated by Testclutch |
|
The private version was added in b0936b8 back in 2000 for "Ultrix" apparently. |
Sign up for free
to join this conversati
549F
on on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not provided as a curlx function so should not be used outside of libcurl.
I strongly suspect that no system we build the test suite on lack strdup so this will not cause any harm.