8000 multi: support mark conncache as stale when network change by Cering · Pull Request #17246 · curl/curl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

multi: support mark conncache as stale when network change #17246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

multi: support mark conncache as stale when network change #17246

wants to merge 7 commits into from
+304 −2

Conversation

Cering
Copy link
Contributor
@Cering Cering commented May 3, 2025 •
edited
Loading

this PR is for fix #17225

curl_multi_setopt add a CURLMOPT_CONNCACHE_STALE option for network changing.

If set CURLMOPT_CONNCACHE_STALE to 1, libcurl ignore all connections in pool that were created earlier than Curl_now() when MSTATE_CONNECT state, in order to prevent their reuse(because these old connections were invalid).

@Cering Cering mentioned this pull request May 3, 2025
Open
@bagder bagder added the feature-window A merge of this requires an open feature window label May 3, 2025
@bagder
Copy link
Member
bagder commented May 3, 2025

Thanks! Here are some good next steps:

  1. Update docs/libcurl/symbols-in-version
  2. Provide at least one test case that shows the feature working
  3. Add documentation so that we can verify that the code seems to work as documented and vice versa

@testclutch
Copy link

Analysis of PR #17246 at 3db12794:

Test 1119 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 540 different CI jobs (the link just goes to one of them).

Test 284 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test 2301 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test 2302 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test 2101 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test 987 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test 988 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

There are more failures, but that's enough from Gha.

Generated by Testclutch

@Cering
Copy link
Contributor Author
Cering commented May 7, 2025 •
edited
Loading

Thanks! Here are some good next steps:

  1. Update docs/libcurl/symbols-in-version
  2. Provide at least one test case that shows the feature working
  3. Add documentation so that we can verify that the code seems to work as documented and vice versa

Done, please check the follow up commits.

@Cering Cering force-pushed the dev branch 3 times, most recently from de7d76c to 251a3c6 Compare May 8, 2025 14:06
@github-actions github-actions bot added the tests label May 8, 2025
@Cering Cering force-pushed the dev branch 5 times, most recently from 0572163 to c39c8d3 Compare May 8, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature-window A merge of this requires an open feature window libcurl API tests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

connection reuse lead to continuous timout after network changed
3 participants
@Cering @bagder @testclutch
0