Perl harmonized errors #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
To do so, we need a generic parser error; overload ParserSingle for the purpose. We used to throw this error at pickle time, which is also weird, but parse time is even more wrong, because we need to cache the error being thrown in order to be able to throw the same error on each line check (which means we got our layering wrong... ah, well).
7a61565 to
ae3391e
Compare
|
After consulting with @mpkorstanje, he'll review in hindsight, if he wants to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Test suite for parse errors is now run too.
⚡️ What's your motivation?
Consistency. The rest is explained in #31.
🏷️ What kind of change is this?
🐛 Bug fix (non-breaking change which fixes a defect)
♻️ Anything particular you want feedback on?
I think this is a minor version at most: the only difference in behaviour is the error code path, which now results in Cucumber Messages (in most cases) instead of exceptions to be caught.
The fact that the exceptions don't auto-stringify anymore doesn't look like a major issue, because they used to be immediately stringified when being thrown (throwing and having a stringification method turn out to be incompatible).
📋 Checklist: