8000 Expand unit tests by poke · Pull Request #53 · ctolkien/Slugify · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Expand unit tests #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2022
Merged

Expand unit tests #53

merged 1 commit into from
Oct 10, 2022

Conversation

poke
Copy link
Contributor
@poke poke commented Oct 9, 2022
  • Add test for double replacement with a reversed order since the order within the dictionary actually matters.
  • Remove upper-case umlaut replacements from standard test since the string replacement happens after the input text is converted to lower-case, so these string replacements are not used.
  • Add additional tests for umlaut replacements without a conversion to lower-case to ensure that the replacement of upper-case characters is independent of the lower-case characters.

@poke
Expand unit tests
5534449 
- Add test for double replacement with a reversed order since the order
  within the dictionary actually matters.
- Remove upper-case umlaut replacements from standard test since the
  string replacement happens after the input text is converted to
  lower-case, so these string replacements are not used.
- Add additional tests for umlaut replacements without a
6976
 conversion to
  lower-case to ensure that the replacement of upper-case characters is
  independent of the lower-case characters.
@ctolkien ctolkien merged commit 8c44560 into ctolkien:master Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@poke @ctolkien
0