8000 Reduce dataset based on zoom by danelkhen · Pull Request #310 · c3js/c3 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Reduce dataset based on zoom #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 4, 2014
Merged

Reduce dataset based on zoom #310

merged 3 commits into from
Jun 4, 2014

Conversation

danelkhen
Copy link
Contributor

Implement c3ext.js, supporting zoom2 behaviour that reduces the dataset when zooming out, and enhances it when zooming in

@danelkhen
Copy link
Contributor Author

Demo can be found here:
http://rawgit.com/danelkhen/c3/feature/autoreduce/htdocs/samples/zoom2.html

@masayuki0812 masayuki0812 merged commit f3ce633 into c3js:master Jun 4, 2014
masayuki0812 added a commit that referenced this pull request Jun 4, 2014
@masayuki0812
Fix trivials of sample for reduction by zoom - #310
6d34bdb
@masayuki0812
Copy link
Member

Merged. I appreciate your work on this. Thank you so much!
I moved the files to extension directory and rename zoom2.html to zoom_reduction.html in htdocs/samples. I'll add this feature to examples in c3js.org.

@danelkhen
Copy link
Contributor Author

Awesome, thanks! I've written utils.js for other stuff as well and added it all into the branch just to make it easy, but I can extract the helper functions needed and get rid of it for the extension to be a single file, which is probably better right?

@masayuki0812
Copy link
Member

Yes, I think so. Could you send me a PR for that? Thanks.

@danelkhen
Copy link
Contributor Author

I will, as soon as I have it.

@danelkhen
Copy link
Contributor Author

Oh, also there's a small typo - can you rename extentions to extensions (it's in the folder and in the urls)

masayuki0812 added a commit that referenced this pull request Jun 4, 2014
@masayuki0812
Fix typo of extensions - #310
f840083
@masayuki0812
Copy link
A800
Member

Oh, sorry.. I think this has been fixed.

@danelkhen danelkhen deleted the feature/autoreduce branch June 4, 2014 14:00
@danelkhen
Copy link
Contributor Author

Cool, PR sent.

@masayuki0812 masayuki0812 mentioned this pull request Jun 5, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danelkhen @masayuki0812
0