Bugfix .selected() api not working #2584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3 selection changed in V4, now returning object not array. .nodes() can be called to return array from selection object. Signed-off-by: liaan <liaan@jerichosystems.co.za>
Signed-off-by: liaan <liaan@jerichosystems.co.za>
d3 selection changed in V4, now returning object not array. .nodes() can be called to return array from selection object. Signed-off-by: liaan <liaan@jerichosystems.co.za>
Signed-off-by: liaan <liaan@jerichosystems.co.za>
Signed-off-by: liaan <liaan@jerichosystems.co.za>
Signed-off-by: liaan <liaan@jerichosystems.co.za>
Codecov Report
@@ Coverage Diff @@
## master #2584 +/- ##
==========================================
+ Coverage 80.54% 80.63% +0.09%
==========================================
Files 54 54
Lines 4282 4282
==========================================
+ Hits 3449 3453 +4
+ Misses 833 829 -4
Continue to review full report at Codecov.
|
kt3k
approved these changes
Mar 22, 2019
beninsocrata
pushed a commit
to socrata/c3
that referenced
this pull request
Oct 31, 2019
* Fix selected api not working. d3 selection changed in V4, now returning object not array. .nodes() can be called to return array from selection object. Signed-off-by: liaan <liaan@jerichosystems.co.za> * Removed merge and unnecessary map. Signed-off-by: liaan <liaan@jerichosystems.co.za> * Fix selected api not working. d3 selection changed in V4, now returning object not array. .nodes() can be called to return array from selection object. Signed-off-by: liaan <liaan@jerichosystems.co.za> * Removed swap file Signed-off-by: liaan <liaan@jerichosystems.co.za> * Implemented basic selected api test in drag functionality tests. Signed-off-by: liaan <liaan@jerichosystems.co.za> * Added test for selected with targetId filter Signed-off-by: liaan <liaan@jerichosystems.co.za>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2477
d3 selection changed in V4, now returning object not array.
.nodes() can be called on selection object to return array from selection object.
Added basic test in drag-spec to test selected api with and without targetId.