Fix levelColor generation and its call for gauges (#2324) #2534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2534 +/- ##
=======================================
Coverage 80.54% 80.54%
=======================================
Files 54 54
Lines 4282 4282
=======================================
Hits 3449 3449
Misses 833 833
Continue to review full report at Codecov.
|
kt3k
approved these changes
Nov 30, 2018
There was a problem hiding this comment.
LGTM
Confirmed the example in #2324 (http://jsfiddle.net/7kYJu/4756/) is fixed with this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix of #2324. Seems to be
arc.js:347is the only line that does not checklevelColorfor emptiness before calling it. Moreover, we can removeconfig.color_pattern.length > 0check and create non-nulllevelColorfunction ifconfig.color_patternis not empty - otherwise undefined color that would be returned fromlevelColordoes not make much sense.