Add spline custom interpolation #1268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With these changes it is possible to set a custom spline interpolation by giving a valid d3 interpolation to spline.interpolation.type. Fixes #479
masayuki0812
added a commit
that referenced
this pull request
Aug 7, 2015
Add spline custom interpolation
|
LGTM. I fixed a bit 782023e, but it's enough to be merged. Thanks!!! |
|
Thank you! 👍 |
kt3k
pushed a commit
that referenced
this pull request
Oct 28, 2018
Options for the type of spline interpolation methods aren't documented -- or at least I couldn't find it in docs. Option was added with #1268
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
These changes add an option to set any custom spline interpolation supported by d3. It would probably make sense to merge the spline and line charts eventually, but I decided to only tackle the problem I was facing for now. Fixes #479.