8000 Calling resize on each and every window resize drammatically slows down the browser by denisvmedia · Pull Request #860 · c3js/c3 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Calling resize on each and every window resize drammatically slows down the browser #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 6, 2015
Merged

Calling resize on each and every window resize drammatically slows down the browser #860

merged 3 commits into from
Jun 6, 2015

Conversation

denisvmedia
Copy link
Contributor

This commit resolves #857

@denisvmedia denisvmedia mentioned this pull request Jan 6, 2015
Closed
@masayuki0812
Copy link
Member
8000 masayuki0812 commented Jan 11, 2015

Hi,
Thank you very much for this fix!! Your code looks nice, but one thing, can you change auto.resize to resize.auto? It looks more c3-way for me.

@denisvmedia
Copy link
Contributor Author

I updated the option name (the first commit in the update has a wrong comment though, but internally it's correct; I'm sorry for that).

@aendra-rininsland
Copy link
Member

Hi @denisvmedia! Could you please squash your commits?

git rebase -i HEAD~3 -- more info

@solgarius solgarius mentioned this pull request 8000 Jan 26, 2015
Open
@rknoll rknoll mentioned this pull request Apr 11, 2015
Merged
@ajainarayanan
Copy link

Is this change still going in by any chance? This improves the performance by so much.

@ajainarayanan ajainarayanan mentioned this pull request May 16, 2015
Merged
masayuki0812 added a commit that referenced this pull request Jun 6, 2015
@masayuki0812
Merge pull request #860 from denisvmedia/master
22fcf44 
Calling resize on each and every window resize drammatically slows down the browser
@masayuki0812 masayuki0812 merged commit 22fcf44 into c3js:master Jun 6, 2015
masayuki0812 added a commit that referenced this pull request Jun 6, 2015
@masayuki0812
Update c3.js and c3.min.js - #860
f620538
@masayuki0812
Copy link
Member

@denisvmedia Sorry for the late response. Thanks!!

@masayuki0812 masayuki0812 mentioned this pull request Aug 6, 2015
Open
@kuhlebrock kuhlebrock mentioned this pull request Jan 16, 2018
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calling resize on each and every window resize drammatically slows down the browser
4 participants
@denisvmedia @masayuki0812 @aendra-rininsland @ajainarayanan
0