8000 cmake: Fix exporting -pthread to pkgconfig by dg0yt · Pull Request #965 · c-ares/c-ares · GitHub

More Web Proxy on the site http://driver.im/

cmake: Fix exporting -pthread to pkgconfig #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

bradh352 merged 1 commit into c-ares:main from dg0yt:pkgconfig

Jan 26, 2025

Contributor

dg0yt commented

Before this change, libcares.pc contained -l-pthread.
Noticed in the vcpkg port.


          cmake: Fix exporting -pthread to pkgconfig

eb85b4e

Member

bradh352 commented

I'm assuming that means THREADS_PREFER_PTHREAD_FLAG is being set somewhere, since that's not otherwise the default behavior in cmake.

Fix seems reasonable though.

Contributor Author

dg0yt commented

I'm assuming that means THREADS_PREFER_PTHREAD_FLAG is being set somewhere, since that's not otherwise the default behavior in cmake.

It is recommended, and it is there:

c-ares/CMakeLists.txt

Line 495 in 8776bf5

SET (CMAKE_THREAD_PREFER_PTHREAD TRUE)

Member

bradh352 commented

odd that docs show THREADS_PREFER_PTHREAD_FLAG as the variable name. https://cmake.org/cmake/help/latest/module/FindThreads.html

bradh352 merged commit d41db1b into c-ares:main

25 of 26 checks passed

Contributor Author

dg0yt commented

You are right, it is a different identifier.

The issue came up in the android builds. Maybe it came from the toolchain. THREADS_PREFER_PTHREAD_FLAG is more a toolchain setting than a project setting - users probably want the same configuration for a given target platform.

dg0yt deleted the pkgconfig branch

January 26, 2025 15:59

bradh352 pushed a commit that referenced this pull request


          cmake: Fix exporting -pthread to static pkgconfig (#965)

642bd8c

Before this change, libcares.pc contained ` -l-pthread`.  

Signed-off-by: Kai Pastor (@dg0yt)

bradh352 pushed a commit that referenced this pull request


          cmake: Fix exporting -pthread to static pkgconfig (#965)

793cbb5

Before this change, libcares.pc contained ` -l-pthread`.  

Signed-off-by: Kai Pastor (@dg0yt)

bradh352 pushed a commit that referenced this pull request


          cmake: Fix exporting -pthread to static pkgconfig (#965)

3f10261

Before this change, libcares.pc contained ` -l-pthread`.

Signed-off-by: Kai Pastor (@dg0yt)

bradh352 pushed a commit that referenced this pull request


          cmake: Fix exporting -pthread to static pkgconfig (#965)

9c7a7cc

Before this change, libcares.pc contained ` -l-pthread`.

Signed-off-by: Kai Pastor (@dg0yt)

bradh352 pushed a commit that referenced this pull request


          cmake: Fix exporting -pthread to static pkgconfig (#965)

c9d4e78

7768

Before this change, libcares.pc contained ` -l-pthread`.

Signed-off-by: Kai Pastor (@dg0yt)

bradh352 pushed a commit that referenced this pull request


          cmake: Fix exporting -pthread to static pkgconfig (#965)

43c019e

Before this change, libcares.pc contained ` -l-pthread`.

Signed-off-by: Kai Pastor (@dg0yt)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

0