Windows UWP (Store) support fix #845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradh352
added a commit
that referenced
this pull request
Aug 2, 2024
Because AppVeyor's version of MSVC needed to be patched to build UWP applications: https://developercommunity.visualstudio.com/t/clexe-compiler-error-C1007-when-compili/10486219 We ended up disabling UWP builds in our CI environment. It turns out UWP support had broken in the meantime: microsoft/vcpkg#40213 This PR fixes the build regression and also adds a GitHub action CI workflow for building the UWP app so we can catch this in the future. Fix By: Brad House (@bradh352)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because AppVeyor's version of MSVC needed to be patched to build UWP applications: https://developercommunity.visualstudio.com/t/clexe-compiler-error-C1007-when-compili/10486219
We ended up disabling UWP builds in our CI environment.
It turns out UWP support had broken in the meantime:
microsoft/vcpkg#40213
This PR fixes the build regression and also adds a GitHub action CI workflow for building the UWP app so we can catch this in the future.
Fix By: Brad House (@bradh352)