Pin setuptools to workaround package_index removal
#193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix broadinstitute#192 , which was caused by the removal of `package_index` from setuptools in pypa/setuptools#4963 . Note that I needed to use `setuptools.build_meta:__legacy__` as `build-backend` (instead of the usual `setuptools.build_meta`) because otherwise `python3 -m build` would fail with: ``` ModuleNotFoundError: No module named 'firecloud' ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #192 , which was caused by the removal of
package_indexfrom setuptools in pypa/setuptools#4963 .Note that I needed to use
setuptools.build_meta:__legacy__asbuild-backend(instead of the usualsetuptools.build_meta) because otherwisepython3 -m buildwould fail with: