include LICENSE file in published crates #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I filed #365 which this PR will resolve. |
|
@Johann150, can you please take a look? This PR will help resolve Chromium bug at https://crbug.com/378272935 |
|
As explained in #365, other repositories need a LICENSE file for reference (as they don't read the manifest file). I see this PR adds symlinks for the sub-crates to reference the main license (thus staying in sync), which should help users of this crate. I believe the release is done on a Linux machine but I think using symlink should also be fine on a Windows machine (I have had success using symlinks with Git on my windows machine). Thanks for this improvement! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The terms of the Apache-2.0 license include a requirement that (re)distributed sources contain a copy of the license text. This is a problem for Linux distributions which need to package the crates from this project (and technically, it's also a problem for redistributing sources via crates.io).
This PR includes a symlink to the LICENSE file in all three published crates, which should make
cargo publishinlude this file when publishing to crates.io. If this project is published from a Windows based machine, full copies of the file might be needed instead.